This repository was archived by the owner on Apr 16, 2020. It is now read-only.

Minimal kernel#6

Merged

MylesBorins merged 7 commits intomasterfrom

Oct 3, 2018

Contributor

MylesBorins commented Oct 2, 2018 •

edited

Loading

Implements everything as documented in nodejs/modules#180

Alternative to #2 and #3

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

MylesBorins requested a review from guybedford

October 2, 2018 05:47

This comment was marked as off-topic.

Sign in to view

MylesBorins force-pushed the minimal-kernel branch from b7d0c9d to 24d1987 Compare

October 2, 2018 05:55

Contributor Author

MylesBorins commented Oct 2, 2018 •

edited

Loading

~~CI: https://ci.nodejs.org/job/node-test-pull-request/17578/~~

This comment was marked as off-topic.

Sign in to view

MylesBorins force-pushed the minimal-kernel branch from 24d1987 to 5a55bd6 Compare

October 2, 2018 06:02

This was referenced Oct 2, 2018

modules: remove file extension and directory resolving for esm #2

Closed

Remove default ".json" and ".node" resolution for ESM #3

Closed

This comment was marked as off-topic.

Sign in to view

Contributor Author

MylesBorins commented Oct 2, 2018

Test release can be found at https://nodejs.org/download/test/v11.0.0-test2018100224d19875fb/

Install via nvm:

$ NVM_NODEJS_ORG_MIRROR=https://nodejs.org/download/test nvm install v11.0.0-test2018100224d19875fb

It may fail right this moment as it is still building

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

MylesBorins force-pushed the minimal-kernel branch 2 times, most recently from dbc26a9 to 39c296d Compare

October 2, 2018 07:03

Contributor Author

MylesBorins commented Oct 2, 2018

ci: https://ci.nodejs.org/job/node-test-pull-request/17581/

joyeecheung mentioned this pull request

CI failures: 20180927-20181002 nodejs/reliability#18

Closed

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

jdalton mentioned this pull request

doc: first pass at minimal-kernel nodejs/modules#180

Merged

MylesBorins added the modules-agenda label

MylesBorins mentioned this pull request

Node.js Foundation Modules Team Meeting 2018-10-03 nodejs/modules#190

Closed

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Contributor Author

MylesBorins commented Oct 3, 2018

We agreed to land this in a meeting with quorum today

One last CI: https://ci.nodejs.org/job/node-test-pull-request/17605/

Will land if green

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

devsnek pushed a commit that referenced this pull request


          esm: remove node specifier resolution algorithm

77a022a

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          doc: document minimal kernel

154f3fe

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: Remove --loader.

692cbb1

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: Remove --experimental-vm-modules.

153deb5

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: remove .json support

1869d52

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: remove .node support

682fed6

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: remove .js support

eb251aa

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: remove node specifier resolution algorithm

6ab6680

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          doc: document minimal kernel

09d5f50

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: Remove --loader.

6e5a331

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: Remove --experimental-vm-modules.

0a55d6d

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: remove node specifier resolution algorithm

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          doc: document minimal kernel

ec83dee

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: Remove --loader.

47e60ec

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

devsnek pushed a commit that referenced this pull request


          esm: Remove --experimental-vm-modules.

47aac7c

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins pushed a commit that referenced this pull request


          esm: remove .json support

a8ac35c

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit that referenced this pull request


          esm: remove .node support

d822a1e

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit that referenced this pull request


          esm: remove .js support

85cf202

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit that referenced this pull request


          esm: remove node specifier resolution algorithm

39d66ab

Refs: nodejs/modules#180

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit that referenced this pull request


          doc: document minimal kernel

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins pushed a commit that referenced this pull request


          esm: Remove --loader.

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins pushed a commit that referenced this pull request


          esm: Remove --experimental-vm-modules.

2fa778b

PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request


          esm: remove .json support

e1544cc

Refs: nodejs/modules#180

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request


          esm: remove .node support

4938fec

Refs: nodejs/modules#180

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request


          esm: remove .js support

2cc5e29

Refs: nodejs/modules#180

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request


          esm: remove node specifier resolution algorithm

436ab26

Refs: nodejs/modules#180

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request


          doc: document minimal kernel

ff3c33c

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request


          esm: Remove --loader.

d31ecbc

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request


          esm: Remove --experimental-vm-modules.

ba42a66

PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <mylesborins@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

GeoffreyBooth mentioned this pull request

Entry points proposal spec and implementation #32

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

9 more reviewers

ljharb ljharb left review comments

michael-ciniawsky michael-ciniawsky left review comments

jdalton jdalton approved these changes

guybedford guybedford approved these changes

DanielRosenwasser DanielRosenwasser approved these changes

targos targos approved these changes

weswigham weswigham approved these changes

zenparsing zenparsing approved these changes

robpalme robpalme approved these changes

Labels